pkg/fixnum/lib/src/intx.dart - Issue 1829113003: Fix --strong warnings in pkg/fixnum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/fixnum/lib/src/intx.dart

Issue 1829113003: Fix --strong warnings in pkg/fixnum (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/fixnum/lib/src/intx.dart

diff --git a/pkg/fixnum/lib/src/intx.dart b/pkg/fixnum/lib/src/intx.dart

index 7adbf0c10b3edf3afebd2d0eedf98c3d7b7767ba..f132affac68ead6d7d061939beb0a2ac5712c06a 100644

--- a/pkg/fixnum/lib/src/intx.dart

+++ b/pkg/fixnum/lib/src/intx.dart

@@ -128,7 +128,7 @@ abstract class IntX implements Comparable<IntX> {

IntX abs();

/** Clamps this integer to be in the range [lowerLimit] - [upperLimit]. */

- IntX clamp(IntX lowerLimit, IntX upperLimit);

+ IntX clamp(lowerLimit, upperLimit);

sra1 2016/03/24 20:50:34 It would be an improvement if the strong mode warn

Leaf 2016/03/24 20:52:49 Acknowledged.

/**

* Returns the minimum number of bits required to store this integer.

« no previous file with comments | « pkg/fixnum/lib/src/int64.dart ('k') | pkg/fixnum/test/int_32_test.dart » ('j') | no next file with comments »