pkg/fixnum/lib/src/int64.dart - Issue 1829113003: Fix --strong warnings in pkg/fixnum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/fixnum/lib/src/int64.dart

Issue 1829113003: Fix --strong warnings in pkg/fixnum (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/fixnum/lib/src/int64.dart

diff --git a/pkg/fixnum/lib/src/int64.dart b/pkg/fixnum/lib/src/int64.dart

index 769ef216423984ab578161a683e4d233542b6e36..7770eb17354c938163ca8cbac7a865be3cf01e60 100644

--- a/pkg/fixnum/lib/src/int64.dart

+++ b/pkg/fixnum/lib/src/int64.dart

@@ -30,7 +30,7 @@ class Int64 implements IntX {

static const int _MASK = 4194303; // (1 << _BITS) - 1

static const int _MASK2 = 1048575; // (1 << _BITS2) - 1

static const int _SIGN_BIT = 19; // _BITS2 - 1

- static const int _SIGN_BIT_MASK = 524288; // 1 << _SIGN_BIT

+ static const int _SIGN_BIT_MASK = 1 << _SIGN_BIT;

/**

* The maximum positive value attainable by an [Int64], namely

« no previous file with comments | « no previous file | pkg/fixnum/lib/src/intx.dart » ('j') | pkg/fixnum/lib/src/intx.dart » ('J')