Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1829113003: Fix --strong warnings in pkg/fixnum (Closed)

Created:
4 years, 9 months ago by sra1
Modified:
4 years, 9 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M pkg/fixnum/lib/src/int64.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fixnum/lib/src/intx.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fixnum/test/int_32_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
https://codereview.chromium.org/1829113003/diff/1/pkg/fixnum/lib/src/intx.dart File pkg/fixnum/lib/src/intx.dart (right): https://codereview.chromium.org/1829113003/diff/1/pkg/fixnum/lib/src/intx.dart#newcode131 pkg/fixnum/lib/src/intx.dart:131: IntX clamp(lowerLimit, upperLimit); It would be an improvement if ...
4 years, 9 months ago (2016-03-24 20:50:34 UTC) #2
Leaf
lgtm https://codereview.chromium.org/1829113003/diff/1/pkg/fixnum/lib/src/intx.dart File pkg/fixnum/lib/src/intx.dart (right): https://codereview.chromium.org/1829113003/diff/1/pkg/fixnum/lib/src/intx.dart#newcode131 pkg/fixnum/lib/src/intx.dart:131: IntX clamp(lowerLimit, upperLimit); On 2016/03/24 20:50:34, sra1 wrote: ...
4 years, 9 months ago (2016-03-24 20:52:49 UTC) #3
sra1
4 years, 9 months ago (2016-03-24 21:14:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e0f749e61d05971ccc10d702d12a102f4345c51b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698