Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 18291002: Fix lint errors in chromium_android.py and chromium_android_unittest.py (Closed)

Created:
7 years, 5 months ago by Steve Block
Modified:
7 years, 5 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Fix lint errors in chromium_android.py and chromium_android_unittest.py The duplicate of ChromiumAndroidTwoPortsTest was added in https://src.chromium.org/viewvc/blink?revision=149345&view=revision R=peter BUG=231188 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153585

Patch Set 1 #

Patch Set 2 : Also fix lint errors in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py View 1 chunk +14 lines, -4 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py View 1 3 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Steve Block
7 years, 5 months ago (2013-06-30 09:14:23 UTC) #1
Steve Block
7 years, 5 months ago (2013-07-04 01:03:00 UTC) #2
Peter Beverloo
lgtm The presubmit hook should have caught this, shouldn't it? Thank you for fixing them, ...
7 years, 5 months ago (2013-07-04 13:15:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/18291002/2001
7 years, 5 months ago (2013-07-04 13:20:47 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-04 14:52:18 UTC) #5
Message was sent while issue was closed.
Change committed as 153585

Powered by Google App Engine
This is Rietveld 408576698