third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp - Issue 1829093002: Use sk_sp-based APIs for SkColorFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp

Issue 1829093002: Use sk_sp-based APIs for SkColorFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bad rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp ('k') | ui/compositor/compositing_recorder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp b/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp

index 0f99b2137d3d4ddcbd1ca2a15ec36412e4ff9572..e249e6060ddf2500b72b722fbaf1df58bfd8deb1 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp

@@ -55,8 +55,9 @@ PassRefPtr<SkImageFilter> SourceAlpha::createImageFilter(SkiaImageFilterBuilder&

0, 0, 0, 0, 0,

0, 0, 0, SK_Scalar1, 0

};

- RefPtr<SkColorFilter> colorFilter(adoptRef(SkColorMatrixFilter::Create(matrix)));

- return adoptRef(SkColorFilterImageFilter::Create(colorFilter.get(), sourceGraphic.get()));

+ return adoptRef(SkColorFilterImageFilter::Create(

+ SkColorFilter::MakeMatrixFilterRowMajor255(matrix).release(),

f(malita) 2016/03/26 14:16:49 Ditto.

+ sourceGraphic.get()));

}

TextStream& SourceAlpha::externalRepresentation(TextStream& ts, int indent) const