Use sk_sp-based APIs for SkColorFilter

cc/output/gl_renderer_unittest.cc

Index: cc/output/gl_renderer_unittest.cc
diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc
index 66f0711e7bba550ede6cd8c7f23e635b93ab4475..ea64431712f1055f6d89172d7c24ffb3b80532cd 100644
--- a/cc/output/gl_renderer_unittest.cc
+++ b/cc/output/gl_renderer_unittest.cc
@@ -1417,10 +1417,9 @@ TEST_F(GLRendererShaderTest, DrawRenderPassQuadShaderPermutations) {
   matrix[13] = matrix[14] = 0;
   matrix[15] = matrix[16] = matrix[17] = matrix[19] = 0;
   matrix[18] = 1;
-  skia::RefPtr<SkColorFilter> color_filter(
-      skia::AdoptRef(SkColorMatrixFilter::Create(matrix)));
-  skia::RefPtr<SkImageFilter> filter = skia::AdoptRef(
-      SkColorFilterImageFilter::Create(color_filter.get(), NULL));
+  skia::RefPtr<SkImageFilter> filter =
+      skia::AdoptRef(SkColorFilterImageFilter::Create(
+          SkColorFilter::MakeMatrixFilterRowMajor255(matrix).release(), NULL));

[f(malita), 2016/03/26 14:16:48]

It's unfortunate that SkColorFilterImageFilter doesn't have a sk_sp factory yet
:(

This pattern leaks (see the ASAN bot): old style/rawptr Create() doesn't
transfer the ref but grabs a new one.  So we can't release the color filter,
because no one is adopting it.  Let's leave it in a sk_sp instead.

Safe pattern:

  sk_sp<SkColorFilter> color_filter =
SkColorFilter::MakeMatrixFilterRowMajor255();
  SkColorFilterImageFilter::Create(color_filter.get()...);

Leaky pattern:

 
SkColorFilterImageFilter::Create(SkColorFilter::MakeMatrixFilterRowMajor255().release()...);

[tomhudson, 2016/03/28 13:11:17]

Done.

Thanks for the thorough review and explanation. I'd just changed all those
things over, not understanding the reference flow well enough, but easy enough
to change back.

   FilterOperations filters;
   filters.Append(FilterOperation::CreateReferenceFilter(filter));