Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: third_party/WebKit/Source/core/paint/SVGPaintContext.cpp

Issue 1829093002: Use sk_sp-based APIs for SkColorFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to reviews Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org> 2 * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org>
3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. All rights reserved. 5 * Copyright (C) 2009 Google, Inc. All rights reserved.
6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
7 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 // TODO(fs): The color filter can set when generating a picture for a mask - 217 // TODO(fs): The color filter can set when generating a picture for a mask -
218 // due to color-interpolation. We could also just apply the 218 // due to color-interpolation. We could also just apply the
219 // color-interpolation property from the the shape itself (which could mean 219 // color-interpolation property from the the shape itself (which could mean
220 // the paintserver if it has it specified), since that would be more in line 220 // the paintserver if it has it specified), since that would be more in line
221 // with the spec for color-interpolation. For now, just steal it from the GC 221 // with the spec for color-interpolation. For now, just steal it from the GC
222 // though. 222 // though.
223 // Additionally, it's not really safe/guaranteed to be correct, as 223 // Additionally, it's not really safe/guaranteed to be correct, as
224 // something down the paint pipe may want to farther tweak the color 224 // something down the paint pipe may want to farther tweak the color
225 // filter, which could yield incorrect results. (Consider just using 225 // filter, which could yield incorrect results. (Consider just using
226 // saveLayer() w/ this color filter explicitly instead.) 226 // saveLayer() w/ this color filter explicitly instead.)
227 paint.setColorFilter(paintInfo.context.colorFilter()); 227 paint.setColorFilter(sk_ref_sp(paintInfo.context.colorFilter()));
228 return true; 228 return true;
229 } 229 }
230 230
231 } // namespace blink 231 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698