Issue 182903004: Merge 167817 "Fix crash in which elementData() might be null."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 182903004: Merge 167817 "Fix crash in which elementData() might be null." (Closed)

Created:
6 years, 9 months ago by chrishtr

Modified:
6 years, 9 months ago

Reviewers:
chrishtr, pdr.

CC:
blink-reviews, shans, eae+blinkwatch, fs, adamk+blink_chromium.org, Steve Block, dino_apple.com, rwlbuis, krit, alancutter (OOO until 2018), Timothy Loh, dstockwell, dglazkov+blink, Eric Willigers, rjwright, sof, gyuyoung.kim_webkit.org, darktears, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1847/

Visibility:
Public.

More Reviews

Description

Merge 167817 "Fix crash in which elementData() might be null." > Fix crash in which elementData() might be null. > > The issue is that an SVG animation may animate the class attribute. SVG tracks attributes, including class, internally. But it still needs to track style recalc dependencies on class, so it hooks into the class change machinery in Element. In order to do so, however, elementData() mus be non-null, which requires calling invalidateSVGElement() while mutating class in the SVG code. > > BUG=345178 > > Review URL: https://codereview.chromium.org/174293005 TBR=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168043

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -0 lines)			Patch
A +	LayoutTests/svg/dom/set-class-attribute.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/svg/dom/set-class-attribute-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
MM	LayoutTests/svg/filters/feColorMatrix-invalid-animation-expected.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/svg/SVGAnimateElement.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

On 2014/02/27 17:58:10, chrishtr wrote:

Lgtm

Expand Messages | Collapse Messages