Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1829023003: Revert of gae_ts_mon: instrument Cloud Endpoint methods (Closed)

Created:
4 years, 9 months ago by Sergiy Byelozyorov
Modified:
4 years, 9 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Revert of gae_ts_mon: instrument Cloud Endpoint methods (patchset #11 id:200001 of https://codereview.chromium.org/1797103003/ ) Reason for revert: Breaks all apps with the following error: Configuration "webapp_django_version" not recognized Traceback (most recent call last): File "/base/data/home/runtimes/python27/python27_lib/versions/1/google/appengine/runtime/wsgi.py", line 240, in Handle handler = _config_handle.add_wsgi_middleware(self._LoadHandler()) File "/base/data/home/runtimes/python27/python27_lib/versions/1/google/appengine/runtime/wsgi.py", line 299, in _LoadHandler handler, path, err = LoadObject(self._handler) File "/base/data/home/runtimes/python27/python27_lib/versions/1/google/appengine/runtime/wsgi.py", line 85, in LoadObject obj = __import__(path[0]) File "/base/data/home/apps/s~chromium-try-flakes/3718-78083c5.391607094608479213/main.py", line 5, in <module> import gae_ts_mon File "/base/data/home/apps/s~chromium-try-flakes/3718-78083c5.391607094608479213/gae_ts_mon/__init__.py", line 38, in <module> from infra_libs.ts_mon.config import initialize File "/base/data/home/apps/s~chromium-try-flakes/3718-78083c5.391607094608479213/gae_ts_mon/config.py", line 14, in <module> import endpoints ImportError: No module named endpoints Original issue's description: > gae_ts_mon: instrument Cloud Endpoint methods > > Introducing a decorator to instrument Cloud Endpoints methods. > > In this version, only status and latency are measured. I'm not yet sure > how to extract request & response sizes; they are probably not accurately > known at the method level. > > BUG=570410 > R=dsansome@chromium.org,nodir@chromium.org > > Committed: https://chromium.googlesource.com/infra/infra/+/d6c85d91f53ea782469c4ea76345d522c37077c2 TBR=dsansome@chromium.org,nodir@chromium.org,sergeyberezin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570410 Committed: https://chromium.googlesource.com/infra/infra/+/1b138f3bd39ebcf6bb92adf93a725c1221ec5183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -308 lines) Patch
D appengine/chromium_try_flakes/.expect_tests.cfg View 1 chunk +0 lines, -2 lines 0 comments Download
M appengine/chromium_try_flakes/handlers/test/flake_issues_test.py View 2 chunks +0 lines, -2 lines 0 comments Download
M appengine/chromium_try_flakes/status/test/cq_status_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine_module/gae_ts_mon/README.md View 2 chunks +0 lines, -11 lines 0 comments Download
M appengine_module/gae_ts_mon/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M appengine_module/gae_ts_mon/config.py View 6 chunks +35 lines, -84 lines 0 comments Download
M appengine_module/gae_ts_mon/test/config_test.py View 6 chunks +18 lines, -130 lines 0 comments Download
M infra_libs/ts_mon/common/http_metrics.py View 1 chunk +0 lines, -21 lines 0 comments Download
M infra_libs/ts_mon/common/interface.py View 2 chunks +2 lines, -9 lines 0 comments Download
D infra_libs/ts_mon/common/test/http_metrics_test.py View 1 chunk +0 lines, -44 lines 0 comments Download
M infra_libs/ts_mon/common/test/interface_test.py View 1 chunk +1 line, -1 line 0 comments Download
M infra_libs/ts_mon/common/test/metrics_test.py View 3 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Sergiy Byelozyorov
Created Revert of gae_ts_mon: instrument Cloud Endpoint methods
4 years, 9 months ago (2016-03-24 20:09:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829023003/1
4 years, 9 months ago (2016-03-24 20:09:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/1b138f3bd39ebcf6bb92adf93a725c1221ec5183
4 years, 9 months ago (2016-03-24 20:09:49 UTC) #4
Sergey Berezin
4 years, 9 months ago (2016-03-24 21:28:20 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698