components/BUILD.gn - Issue 1829023002: Add fake for InstanceIDWithSubtype.java, in order to re-use unit test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/BUILD.gn

Issue 1829023002: Add fake for InstanceIDWithSubtype.java, in order to re-use unit test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid2jni

Patch Set: Move FakeInstanceIDWithSubtype to javatests/ Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/components_tests.gyp » ('j') | components/gcm_driver/instance_id/android/java/src/org/chromium/components/gcm_driver/instance_id/InstanceIDBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/BUILD.gn

diff --git a/components/BUILD.gn b/components/BUILD.gn

index 2f721dff6437d11c5005db9dbe756709d5f9f85b..3bfd7f5394cc539e3cd0b6e9412df065efb30725 100644

--- a/components/BUILD.gn

+++ b/components/BUILD.gn

@@ -148,6 +148,7 @@ test("components_unittests") {

"//components/favicon_base:unit_tests",

"//components/gcm_driver:unit_tests",

"//components/gcm_driver/crypto:unit_tests",

+ "//components/gcm_driver/instance_id:unit_tests",

"//components/guest_view/browser:unit_tests",

"//components/history/content/browser:unit_tests",

"//components/history/core/browser:unit_tests",

@@ -221,6 +222,8 @@ test("components_unittests") {

isolate_file = "components_unittests.isolate"

deps += [

+ "//components/gcm_driver/instance_id/android:instance_id_driver_java",

+ "//components/gcm_driver/instance_id/android:instance_id_driver_test_support_java",

"//components/invalidation/impl",

"//components/invalidation/impl:java",

"//components/safe_json",

@@ -232,7 +235,6 @@ test("components_unittests") {

"//components/web_restrictions:test_support_java",

"//components/web_restrictions:unit_tests",

"//content/public/android:content_java",

- "//content/public/android:content_java",

"//content/public/browser",

"//net",

"//ui/android:ui_java",

@@ -251,7 +253,6 @@ test("components_unittests") {

"//components/audio_modem:unit_tests",

"//components/copresence:unit_tests",

"//components/feedback:unit_tests",

- "//components/gcm_driver/instance_id:unit_tests",

Peter Beverloo 2016/04/15 00:00:17 This affects iOS as well as Android. Is that inten

johnme 2016/04/15 16:00:42 No, I moved it from (!is_android && !is_ios) to !i

"//components/proximity_auth:unit_tests",

"//components/storage_monitor:unit_tests",

"//components/web_modal:unit_tests",