chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc - Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api

Patch Set: Fix hongbo's comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc ('K') | « chrome/browser/extensions/api/system_info_memory/system_info_memory_api.cc ('k') | chrome/browser/extensions/api/system_info_storage/storage_info_provider.h » ('j') | chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc

diff --git a/chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc b/chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc

index a101640f71c5178b1e9ca0f51b1826d03329dfc8..4885e63138d228d0c8195725a3665795fe4a0bf6 100644

--- a/chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc

+++ b/chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc

@@ -20,7 +20,8 @@ class MockMemoryInfoProviderImpl : public MemoryInfoProvider {

public:

MockMemoryInfoProviderImpl() {}

- virtual bool QueryInfo(MemoryInfo* info) OVERRIDE {

+ virtual bool QueryInfo() OVERRIDE {

+ MemoryInfo* info = &info_;

info->capacity = 4096;

info->available_capacity = 1024;

return true;