Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Unified Diff: chrome/browser/extensions/api/system_info_memory/memory_info_provider_unittest.cc

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api
Patch Set: Fix hongbo's comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_info_memory/memory_info_provider_unittest.cc
diff --git a/chrome/browser/extensions/api/system_info_memory/memory_info_provider_unittest.cc b/chrome/browser/extensions/api/system_info_memory/memory_info_provider_unittest.cc
index 9e008b37be4e99d02276a540e5a25fed72535e7a..85f98dac7961e277e055df0124ce793a44842026 100644
--- a/chrome/browser/extensions/api/system_info_memory/memory_info_provider_unittest.cc
+++ b/chrome/browser/extensions/api/system_info_memory/memory_info_provider_unittest.cc
@@ -20,16 +20,16 @@ const struct TestMemoryInfo kTestingMemoryInfoData = { 4096.0, 1024.0 };
class TestMemoryInfoProvider : public MemoryInfoProvider {
public:
- virtual bool QueryInfo(MemoryInfo* info) OVERRIDE;
+ virtual bool QueryInfo() OVERRIDE;
+
private:
virtual ~TestMemoryInfoProvider();
};
TestMemoryInfoProvider::~TestMemoryInfoProvider() {}
-bool TestMemoryInfoProvider::QueryInfo(MemoryInfo* info) {
- if (info == NULL)
- return false;
+bool TestMemoryInfoProvider::QueryInfo() {
+ MemoryInfo* info = &info_;
info->capacity = kTestingMemoryInfoData.capacity;
info->available_capacity = kTestingMemoryInfoData.available_capacity;
return true;
@@ -48,11 +48,11 @@ MemoryInfoProviderTest::MemoryInfoProviderTest()
}
TEST_F(MemoryInfoProviderTest, QueryMemoryInfo) {
- scoped_ptr<MemoryInfo> memory_info(new MemoryInfo());
- EXPECT_TRUE(memory_info_provider_->QueryInfo(memory_info.get()));
- EXPECT_DOUBLE_EQ(kTestingMemoryInfoData.capacity, memory_info->capacity);
+ EXPECT_TRUE(memory_info_provider_->QueryInfo());
+ EXPECT_DOUBLE_EQ(kTestingMemoryInfoData.capacity,
+ memory_info_provider_->memory_info().capacity);
EXPECT_DOUBLE_EQ(kTestingMemoryInfoData.available_capacity,
- memory_info->available_capacity);
+ memory_info_provider_->memory_info().available_capacity);
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698