chrome/browser/extensions/api/system_info_display/system_info_display_api.cc - Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_display/system_info_display_api.cc

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api

Patch Set: Fix hongbo's comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc ('K') | « chrome/browser/extensions/api/system_info_display/system_info_display_api.h ('k') | chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc » ('j') | chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_display/system_info_display_api.cc

diff --git a/chrome/browser/extensions/api/system_info_display/system_info_display_api.cc b/chrome/browser/extensions/api/system_info_display/system_info_display_api.cc

index 2c20e673ab953d0f86339525f03555226f13db50..d2c8748facdbb096a14b00233c2b020ba959349a 100644

--- a/chrome/browser/extensions/api/system_info_display/system_info_display_api.cc

+++ b/chrome/browser/extensions/api/system_info_display/system_info_display_api.cc

@@ -22,9 +22,10 @@ bool SystemInfoDisplayGetDisplayInfoFunction::RunImpl() {

}

void SystemInfoDisplayGetDisplayInfoFunction::OnGetDisplayInfoCompleted(

- const DisplayInfo& info, bool success) {

+ bool success) {

if (success) {

- results_ = api::system_info_display::GetDisplayInfo::Results::Create(info);

+ results_ = api::system_info_display::GetDisplayInfo::Results::Create(

+ DisplayInfoProvider::GetProvider()->display_info());

} else {

SetError("Error occurred when querying display information.");

}