Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api
Patch Set: Fix hongbo's comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc
diff --git a/chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc b/chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc
index 46d50625b635b1fd7570d3cd4c77464485cb3e49..58218ced271689b3b4cdfd708adb0fc1773f260c 100644
--- a/chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc
+++ b/chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc
@@ -40,7 +40,7 @@ const struct TestDisplayInfo kTestingDisplayInfoData[] = {
class TestDisplayInfoProvider : public DisplayInfoProvider {
public:
- virtual bool QueryInfo(DisplayInfo* info) OVERRIDE;
+ virtual bool QueryInfo() OVERRIDE;
private:
virtual ~TestDisplayInfoProvider();
@@ -48,9 +48,8 @@ class TestDisplayInfoProvider : public DisplayInfoProvider {
TestDisplayInfoProvider::~TestDisplayInfoProvider() {}
-bool TestDisplayInfoProvider::QueryInfo(DisplayInfo* info) {
- if (info == NULL)
- return false;
+bool TestDisplayInfoProvider::QueryInfo() {
+ DisplayInfo* info = &info_;
info->clear();
for (size_t i = 0; i < arraysize(kTestingDisplayInfoData); ++i) {
linked_ptr<DisplayUnitInfo> unit(new DisplayUnitInfo());
@@ -87,12 +86,12 @@ DisplayInfoProviderTest::DisplayInfoProviderTest()
}
TEST_F(DisplayInfoProviderTest, QueryDisplayInfo) {
- scoped_ptr<DisplayInfo> display_info(new DisplayInfo());
- EXPECT_TRUE(display_info_provider_->QueryInfo(display_info.get()));
- EXPECT_EQ(arraysize(kTestingDisplayInfoData), display_info->size());
+ EXPECT_TRUE(display_info_provider_->QueryInfo());
+ const DisplayInfo& display_info = display_info_provider_->display_info();
+ EXPECT_EQ(arraysize(kTestingDisplayInfoData), display_info.size());
for (size_t i = 0; i < arraysize(kTestingDisplayInfoData); ++i) {
const linked_ptr<api::system_info_display::DisplayUnitInfo> unit =
- (*display_info.get())[i];
+ display_info[i];
EXPECT_EQ(kTestingDisplayInfoData[i].id, unit->id);
EXPECT_EQ(kTestingDisplayInfoData[i].name, unit->name);
EXPECT_DOUBLE_EQ(kTestingDisplayInfoData[i].dpi_x, unit->dpi_x);

Powered by Google App Engine
This is Rietveld 408576698