chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc - Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api

Patch Set: Fix hongbo's comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/system_info/system_info_provider.h ('K') | « chrome/browser/extensions/api/system_info_display/display_info_provider.cc ('k') | chrome/browser/extensions/api/system_info_display/display_info_provider_mac.cc » ('j') | chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc

diff --git a/chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc b/chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc

index 7ce7621ec7a6a09b968ac9336a32bee44f12f3db..d27805bb636a66bcd86b7d04e78d96b5a2b25fff 100644

--- a/chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc

+++ b/chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc

@@ -411,12 +411,11 @@ bool SetInfoImpl(const std::string& display_id_str,

} // namespace

void DisplayInfoProvider::RequestInfo(const RequestInfoCallback& callback) {

- DisplayInfo requested_info;

- bool success = QueryInfo(&requested_info);

+ QueryInfo();

base::MessageLoopProxy::current()->PostTask(

FROM_HERE,

- base::Bind(callback, requested_info, success));

+ base::Bind(callback, info_, success_));

Hongbo Min 2013/07/05 05:01:34 nits: sucess_ should be already removed, use the r

Haojian Wu 2013/07/06 05:31:37 Done.

}

void DisplayInfoProvider::SetInfo(const std::string& display_id,