Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api
Patch Set: Fix hongbo's comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc
diff --git a/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc b/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc
index edc56fe2ff52f729d138d57ff5738797bc63963a..39b840027d804ee40656f2f568059c376c019799 100644
--- a/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc
+++ b/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc
@@ -14,9 +14,12 @@ CpuInfoProvider::CpuInfoProvider() {}
CpuInfoProvider::~CpuInfoProvider() {}
-bool CpuInfoProvider::QueryInfo(CpuInfo* info) {
- if (info == NULL)
- return false;
+const CpuInfo& CpuInfoProvider::cpu_info() const {
+ return info_;
+}
+
+bool CpuInfoProvider::QueryInfo() {
+ CpuInfo* info = &info_;
info->num_of_processors = base::SysInfo::NumberOfProcessors();
info->arch_name = base::SysInfo::OperatingSystemArchitecture();

Powered by Google App Engine
This is Rietveld 408576698