chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc - Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api

Patch Set: Update Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/system_info/system_info_provider.h ('K') | « chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.h ('k') | chrome/browser/extensions/api/system_info_cpu/cpu_info_provider_unittest.cc » ('j') | chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc

diff --git a/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc b/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc

index edc56fe2ff52f729d138d57ff5738797bc63963a..9e3dfc3c77c3e74ecd5e9ec3dfd2be6a5aec7db5 100644

--- a/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc

+++ b/chrome/browser/extensions/api/system_info_cpu/cpu_info_provider.cc

@@ -14,13 +14,14 @@ CpuInfoProvider::CpuInfoProvider() {}

CpuInfoProvider::~CpuInfoProvider() {}

-bool CpuInfoProvider::QueryInfo(CpuInfo* info) {

- if (info == NULL)

- return false;

+const CpuInfo& CpuInfoProvider::cpu_info() const {

+ return info_;

- info->num_of_processors = base::SysInfo::NumberOfProcessors();

- info->arch_name = base::SysInfo::OperatingSystemArchitecture();

- info->model_name = base::SysInfo::CPUModelName();

+bool CpuInfoProvider::QueryInfo() {

+ info_.num_of_processors = base::SysInfo::NumberOfProcessors();

+ info_.arch_name = base::SysInfo::OperatingSystemArchitecture();

+ info_.model_name = base::SysInfo::CPUModelName();

return true;

}