chrome/browser/extensions/api/system_info_memory/memory_info_provider.h - Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_memory/memory_info_provider.h

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api

Patch Set: Pass chromeos unit_tests Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/system_info_display/system_info_display_apitest.cc ('k') | chrome/browser/extensions/api/system_info_memory/memory_info_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_memory/memory_info_provider.h

diff --git a/chrome/browser/extensions/api/system_info_memory/memory_info_provider.h b/chrome/browser/extensions/api/system_info_memory/memory_info_provider.h

index 589d3acf95769eaf5f1284d5171917c0b774c5e3..d9200364c707982fd639f8213e788aabc31fb3b6 100644

--- a/chrome/browser/extensions/api/system_info_memory/memory_info_provider.h

+++ b/chrome/browser/extensions/api/system_info_memory/memory_info_provider.h

@@ -17,8 +17,9 @@ class MemoryInfoProvider

static MemoryInfoProvider* Get();

// Overriden from SystemInfoProvider<MemoryInfo>.

- virtual bool QueryInfo(

- api::system_info_memory::MemoryInfo* info) OVERRIDE;

+ virtual bool QueryInfo() OVERRIDE;

+ const api::system_info_memory::MemoryInfo& memory_info() const;

private:

friend class SystemInfoProvider<