chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc - Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc ('K') | « chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc

diff --git a/chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc b/chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc

index 2d27dbed34719127b0abf39a2fa94b5f7bcdadd6..676d017a2139d9289fd6ac5c19ef66099cb5356b 100644

--- a/chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc

+++ b/chrome/browser/extensions/api/system_info_storage/test_storage_info_provider.cc

@@ -39,7 +39,8 @@ chrome::StorageInfo TestStorageInfoProvider::BuildStorageInfo(

return info;

}

-bool TestStorageInfoProvider::QueryInfo(extensions::StorageInfo* info) {

+void TestStorageInfoProvider::QueryInfo() {

+ extensions::StorageInfo* info = &info_;

extensions::StorageInfo results;

for (size_t i = 0; i < testing_data_.size(); ++i) {

linked_ptr<StorageUnitInfo> unit(new StorageUnitInfo());

@@ -51,7 +52,7 @@ bool TestStorageInfoProvider::QueryInfo(extensions::StorageInfo* info) {

results.push_back(unit);

}

info->swap(results);

- return true;

+ success_ = true;

}

std::vector<chrome::StorageInfo>