chrome/browser/extensions/api/system_info_storage/storage_info_provider.h - Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_storage/storage_info_provider.h

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/system_info/system_info_provider.h ('K') | « chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc ('k') | chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc » ('j') | chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_storage/storage_info_provider.h

diff --git a/chrome/browser/extensions/api/system_info_storage/storage_info_provider.h b/chrome/browser/extensions/api/system_info_storage/storage_info_provider.h

index b53a7c3801107d7342c43a8df8797dc81dc41513..544fdfa6c18606216dda09c58a3943254b0bb480 100644

--- a/chrome/browser/extensions/api/system_info_storage/storage_info_provider.h

+++ b/chrome/browser/extensions/api/system_info_storage/storage_info_provider.h

@@ -62,6 +62,8 @@ class StorageInfoProvider : public SystemInfoProvider<StorageInfo> {

virtual std::string GetDeviceIdForTransientId(

const std::string& transient_id) const;

+ const StorageInfo* storage_info() const;

protected:

virtual ~StorageInfoProvider();

@@ -69,7 +71,7 @@ class StorageInfoProvider : public SystemInfoProvider<StorageInfo> {

void SetWatchingIntervalForTesting(size_t ms) { watching_interval_ = ms; }

// SystemInfoProvider implementations.

- virtual bool QueryInfo(StorageInfo* info) OVERRIDE;

+ virtual void QueryInfo() OVERRIDE;

virtual void StartQueryInfoImpl() OVERRIDE;

private: