[SystemInfo API] Finish TODOs in SystemInfoProvider

chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc

Index: chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc
diff --git a/chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc b/chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc
index 46d50625b635b1fd7570d3cd4c77464485cb3e49..9ffdc8260f61460b8a117f946e7f42c1173ef2b9 100644
--- a/chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc
+++ b/chrome/browser/extensions/api/system_info_display/display_info_provider_unittest.cc
@@ -40,17 +40,17 @@ const struct TestDisplayInfo kTestingDisplayInfoData[] = {
 
 class TestDisplayInfoProvider : public DisplayInfoProvider {
  public:
-  virtual bool QueryInfo(DisplayInfo* info) OVERRIDE;
+  virtual void QueryInfo() OVERRIDE;
 
+  const DisplayInfo* display_info() const;
  private:
   virtual ~TestDisplayInfoProvider();
 };
 
 TestDisplayInfoProvider::~TestDisplayInfoProvider() {}
 
-bool TestDisplayInfoProvider::QueryInfo(DisplayInfo* info) {
-  if (info == NULL)
-    return false;
+void TestDisplayInfoProvider::QueryInfo() {
+  DisplayInfo* info = &info_;
   info->clear();
   for (size_t i = 0; i < arraysize(kTestingDisplayInfoData); ++i) {
     linked_ptr<DisplayUnitInfo> unit(new DisplayUnitInfo());
@@ -71,7 +71,11 @@ bool TestDisplayInfoProvider::QueryInfo(DisplayInfo* info) {
     unit->work_area.height = kTestingDisplayInfoData[i].work_area.height;
     info->push_back(unit);
   }
-  return true;
+  success_ = true;
+}
+
+const DisplayInfo* TestDisplayInfoProvider::display_info() const {
+  return &info_;
 }
 
 class DisplayInfoProviderTest : public testing::Test {
@@ -87,12 +91,12 @@ DisplayInfoProviderTest::DisplayInfoProviderTest()
 }
 
 TEST_F(DisplayInfoProviderTest, QueryDisplayInfo) {
-  scoped_ptr<DisplayInfo> display_info(new DisplayInfo());
-  EXPECT_TRUE(display_info_provider_->QueryInfo(display_info.get()));
+  display_info_provider_->QueryInfo();
+  const DisplayInfo* display_info = display_info_provider_->display_info();
   EXPECT_EQ(arraysize(kTestingDisplayInfoData), display_info->size());
   for (size_t i = 0; i < arraysize(kTestingDisplayInfoData); ++i) {
     const linked_ptr<api::system_info_display::DisplayUnitInfo> unit =
-        (*display_info.get())[i];
+        (*display_info)[i];
     EXPECT_EQ(kTestingDisplayInfoData[i].id, unit->id);
     EXPECT_EQ(kTestingDisplayInfoData[i].name, unit->name);
     EXPECT_DOUBLE_EQ(kTestingDisplayInfoData[i].dpi_x, unit->dpi_x);