Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2778)

Unified Diff: chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc

Issue 18290002: [SystemInfo API] Finish TODOs in SystemInfoProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dev_rewrite_storage_info_api
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc
diff --git a/chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc b/chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc
index 7ce7621ec7a6a09b968ac9336a32bee44f12f3db..a9dd2687201ebdb59ba2adaeb8ff621802dd8e65 100644
--- a/chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc
+++ b/chrome/browser/extensions/api/system_info_display/display_info_provider_chromeos.cc
@@ -411,12 +411,11 @@ bool SetInfoImpl(const std::string& display_id_str,
} // namespace
void DisplayInfoProvider::RequestInfo(const RequestInfoCallback& callback) {
- DisplayInfo requested_info;
- bool success = QueryInfo(&requested_info);
+ QueryInfo();
base::MessageLoopProxy::current()->PostTask(
FROM_HERE,
- base::Bind(callback, requested_info, success));
+ base::Bind(callback, info_, success_));
}
void DisplayInfoProvider::SetInfo(const std::string& display_id,
@@ -429,7 +428,7 @@ void DisplayInfoProvider::SetInfo(const std::string& display_id,
base::Bind(callback, success, error));
}
-bool DisplayInfoProvider::QueryInfo(DisplayInfo* info) {
+void DisplayInfoProvider::QueryInfo(DisplayInfo* info) {
DCHECK(info);
info->clear();
@@ -443,7 +442,7 @@ bool DisplayInfoProvider::QueryInfo(DisplayInfo* info) {
primary_id, info);
}
- return true;
+ success_ = true;
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698