Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1828973002: Add the --build-summary-exclude-informative flag. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add the --build-summary-exclude-informative flag. It (in combination with --build-summary-only-diet) makes the package:path summary is almost 3 times smaller, partially because of skipping bodies, patially because of excluding documentation comments, and partially because of making 'codeRange' fields informative. We also remove MD5 hashes. As I can see after changes in method bodies we generate the exactly same file (or at least 'cmp -l' thinks so). Adding a new field results in a file of different length. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/58bde1b3b4ba671e37539522a364c0a21bccb5de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -4 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 32 chunks +298 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 8 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 4 chunks +33 lines, -1 line 0 comments Download
M pkg/analyzer/tool/summary/idl_model.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-24 05:37:27 UTC) #1
Paul Berry
lgtm
4 years, 9 months ago (2016-03-24 11:30:10 UTC) #2
scheglov
4 years, 9 months ago (2016-03-24 15:20:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58bde1b3b4ba671e37539522a364c0a21bccb5de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698