Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1828953003: 🌿 Fix stack tool when packed relocations exist and built with GN (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix stack tool when packed relocations exist and built with GN BUG=none Committed: https://crrev.com/28ab0e6e04911af66c935e963a2970ff0f7b45f6 Cr-Commit-Position: refs/heads/master@{#383978}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -45 lines) Patch
M third_party/android_platform/development/scripts/stack View 1 8 chunks +15 lines, -40 lines 0 comments Download
M third_party/android_platform/development/scripts/stack_libs.py View 2 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
agrieve
4 years, 9 months ago (2016-03-24 19:03:02 UTC) #2
agrieve
On 2016/03/24 19:03:02, agrieve wrote: rmcilroy->sgurun (Ross is OOO)
4 years, 8 months ago (2016-03-29 15:19:45 UTC) #5
sgurun-gerrit only
lgtm
4 years, 8 months ago (2016-03-29 18:32:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828953003/20001
4 years, 8 months ago (2016-03-30 14:18:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 14:49:55 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 14:51:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28ab0e6e04911af66c935e963a2970ff0f7b45f6
Cr-Commit-Position: refs/heads/master@{#383978}

Powered by Google App Engine
This is Rietveld 408576698