Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1828923004: Remove even more headers from base/memory/scoped_ptr.h (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
danakj, Wez
CC:
anandc+watch-blimp_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, dtrainor+watch-blimp_chromium.org, gavinp+memory_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove even more headers from base/memory/scoped_ptr.h BUG=554298 Committed: https://crrev.com/aae5da04db59003185732997f5b9ddb909861d91 Cr-Commit-Position: refs/heads/master@{#383315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M base/memory/scoped_ptr.h View 1 chunk +0 lines, -4 lines 0 comments Download
M blimp/common/logging.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/rejecting_authenticator.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dcheng
This has been surprisingly easy so far. Writing the script was completely overkill. …suspiciously easy, ...
4 years, 9 months ago (2016-03-25 05:04:46 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828923004/1
4 years, 9 months ago (2016-03-25 05:04:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 06:45:21 UTC) #6
Wez
lgtm
4 years, 9 months ago (2016-03-25 18:18:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828923004/1
4 years, 9 months ago (2016-03-25 18:19:08 UTC) #9
danakj
LGTM
4 years, 9 months ago (2016-03-25 18:20:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 18:24:24 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 18:25:16 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aae5da04db59003185732997f5b9ddb909861d91
Cr-Commit-Position: refs/heads/master@{#383315}

Powered by Google App Engine
This is Rietveld 408576698