Issue 1828903002: Fix for analyze-cli and Dart SDK options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1828903002: Fix for analyze-cli and Dart SDK options. (Closed)

Created:
4 years, 9 months ago by scheglov

Modified:
4 years, 9 months ago

Reviewers:
pquitslund, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for analyze-cli and Dart SDK options. Fix for one more problem with my analysisOptions change. We should set it early and don't attempt to change it later. Not sure how well it will work with Flutter and other non-standard SDKs. R=brianwilkerson@google.com, pquitslund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ef04426f1754c085307f65035943ba3bc76314c5

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -11 lines)			Patch
	M	pkg/analyzer_cli/lib/src/driver.dart	View		2 chunks	+18 lines, -11 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 9 months ago (2016-03-23 21:53:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ef04426f1754c085307f65035943ba3bc76314c5 (presubmit successful).