Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 1828833002: Fix another painting regression caused by my patch to address painting problems with the fullscreen… (Closed)

Created:
4 years, 9 months ago by ananta
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix another painting regression caused by my patch to address painting problems with the fullscreen window 1 px reduction. We are setting the size of the compositor as that returned by the DesktopWindowTreeHostWin::GetBounds call. That function returns the window size offset by the window expansion and window enlargement rectangles, which is not the correct size. Fix is to pass the bounds size as returned by the HWNDMessageHandler. BUG=597244 Committed: https://crrev.com/5a941ea1cd19d6a92d197e16ab4508652ff139d0 Cr-Commit-Position: refs/heads/master@{#382934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ananta
4 years, 9 months ago (2016-03-23 19:41:16 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-23 21:36:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828833002/1
4 years, 9 months ago (2016-03-23 21:51:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 21:57:29 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 22:00:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a941ea1cd19d6a92d197e16ab4508652ff139d0
Cr-Commit-Position: refs/heads/master@{#382934}

Powered by Google App Engine
This is Rietveld 408576698