Media permissions: Remove plumbing for insecure pepper requests in Chrome

Media permissions: Remove plumbing for insecure pepper requests in Chrome

Previously, getUserMedia requests would not persist decisions on
insecure origins, but media requests from insecure origins through
Pepper would be persisted. However, since M47, getUserMedia requests
from insecure origins are blocked in the renderer, so differentiating
between pepper and non-pepper requests is no longer necessary to know
whether to store the permission decision (any such request is a
Pepper request and can be stored).

This CL removes the plumbing for Pepper requests from the media
permission layer, since it is no longer needed.

BUG=596786
Committed: https://crrev.com/e5d5c191121280aa0223615b10d8ab21197ff9b2
Cr-Commit-Position: refs/heads/master@{#399078}

[tsergeant, 2016-03-24 02:17:22]

Description was changed from

==========
Media permissions: Remove plumbing for insecure pepper requests in Chrome

This was only necessary while getusermedia requests on insecure origins were
deprecatedi and did not allow permissions to be stored. Now that they are
entirely removed, it was adding complexity with no benefit.

BUG=596786
==========

to

==========
Media permissions: Remove plumbing for insecure pepper requests in Chrome

Previously, getUserMedia requests would not persist decisions on insecure
origins, except for media requests from pepper, which would be persisted.

However, since M47, getUserMedia requests from insecure origins are
entirely disabled, so differentiating between pepper and non-pepper
requests is no longer necessary to know whether to store the permission
decision.

This CL removes the plumbing for Pepper requests from the media
permission layer.

BUG=596786
==========

[tsergeant, 2016-05-31 03:17:28]

Patchset #1 (id:1) has been deleted

[tsergeant, 2016-05-31 03:29:03]

Description was changed from

==========
Media permissions: Remove plumbing for insecure pepper requests in Chrome

Previously, getUserMedia requests would not persist decisions on insecure
origins, except for media requests from pepper, which would be persisted.

However, since M47, getUserMedia requests from insecure origins are
entirely disabled, so differentiating between pepper and non-pepper
requests is no longer necessary to know whether to store the permission
decision.

This CL removes the plumbing for Pepper requests from the media
permission layer.

BUG=596786
==========

to

==========
Media permissions: Remove plumbing for insecure pepper requests in Chrome

Previously, getUserMedia requests would not persist decisions on
insecure origins, but media requests from insecure origins through
Pepper would be persisted. However, since M47, getUserMedia requests
from insecure origins are blocked in the renderer, so differentiating
between pepper and non-pepper requests is no longer necessary to know
whether to store the permission decision (any such request is a
Pepper request and can be stored).

This CL removes the plumbing for Pepper requests from the media
permission layer.

BUG=596786
==========

[tsergeant, 2016-05-31 03:31:40]

Description was changed from

==========
Media permissions: Remove plumbing for insecure pepper requests in Chrome

Previously, getUserMedia requests would not persist decisions on
insecure origins, but media requests from insecure origins through
Pepper would be persisted. However, since M47, getUserMedia requests
from insecure origins are blocked in the renderer, so differentiating
between pepper and non-pepper requests is no longer necessary to know
whether to store the permission decision (any such request is a
Pepper request and can be stored).

This CL removes the plumbing for Pepper requests from the media
permission layer.

BUG=596786
==========

to

==========
Media permissions: Remove plumbing for insecure pepper requests in Chrome

Previously, getUserMedia requests would not persist decisions on
insecure origins, but media requests from insecure origins through
Pepper would be persisted. However, since M47, getUserMedia requests
from insecure origins are blocked in the renderer, so differentiating
between pepper and non-pepper requests is no longer necessary to know
whether to store the permission decision (any such request is a
Pepper request and can be stored).

This CL removes the plumbing for Pepper requests from the media
permission layer, since it is no longer needed.

BUG=596786
==========

[tsergeant, 2016-05-31 03:32:01]

tsergeant@chromium.org changed reviewers:
+ raymes@chromium.org

[tsergeant, 2016-05-31 03:32:01]

As discussed, PTAL

[raymes, 2016-06-06 05:11:10]

https://codereview.chromium.org/1828803003/diff/60001/chrome/browser/media/me...
File chrome/browser/media/media_stream_device_permission_context.cc (right):

https://codereview.chromium.org/1828803003/diff/60001/chrome/browser/media/me...
chrome/browser/media/media_stream_device_permission_context.cc:38: return
GetPermissionStatusInternal(requesting_origin, embedding_origin);
nit: should we inline this now?

https://codereview.chromium.org/1828803003/diff/60001/chrome/browser/media/me...
chrome/browser/media/media_stream_device_permission_context.cc:93: return
CONTENT_SETTING_ASK;
I don't *think* we should ever hit this anymore.

I think we can delete this block and ShouldPersistContentSetting. The other two
places where it is used it is just used to check whether we should call
SetContentSetting. But that function will already check if the patterns are
valid.

[tsergeant, 2016-06-06 07:19:33]

https://codereview.chromium.org/1828803003/diff/60001/chrome/browser/media/me...
File chrome/browser/media/media_stream_device_permission_context.cc (right):

https://codereview.chromium.org/1828803003/diff/60001/chrome/browser/media/me...
chrome/browser/media/media_stream_device_permission_context.cc:38: return
GetPermissionStatusInternal(requesting_origin, embedding_origin);
On 2016/06/06 05:11:10, raymes wrote:
> nit: should we inline this now?

Done.

https://codereview.chromium.org/1828803003/diff/60001/chrome/browser/media/me...
chrome/browser/media/media_stream_device_permission_context.cc:93: return
CONTENT_SETTING_ASK;
On 2016/06/06 05:11:10, raymes wrote:
> I don't *think* we should ever hit this anymore.
> 
> I think we can delete this block and ShouldPersistContentSetting. The other
two
> places where it is used it is just used to check whether we should call
> SetContentSetting. But that function will already check if the patterns are
> valid.

Cool, I've removed it (I was unsure about whether the valid check was still
necessary).

[raymes, 2016-06-06 07:51:50]

lgtm

[tsergeant, 2016-06-08 03:00:13]

tsergeant@chromium.org changed reviewers:
+ sergeyu@chromium.org

[tsergeant, 2016-06-08 03:00:14]

+sergeyu for chrome/browser/media

[Sergey Ulanov, 2016-06-08 22:12:20]

lgtm

[tsergeant, 2016-06-08 23:50:10]

tsergeant@chromium.org changed reviewers:
+ tnagel@chromium.org

[tsergeant, 2016-06-08 23:50:11]

+tnagel@ for policy_browsertest.cc

[Thiemo Nagel, 2016-06-09 09:54:54]

On 2016/06/08 23:50:11, tsergeant wrote:
> +tnagel@ for policy_browsertest.cc

chrome/browser/policy LGTM

[tsergeant, 2016-06-09 23:01:14]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-06-09 23:01:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828803003/80001

[commit-bot: I haz the power, 2016-06-10 01:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 01:03:48]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[tsergeant, 2016-06-10 03:29:49]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-06-10 03:30:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828803003/80001

[commit-bot: I haz the power, 2016-06-10 03:35:38]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-06-10 03:35:54]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 03:36:41]

Description was changed from

==========
Media permissions: Remove plumbing for insecure pepper requests in Chrome

Previously, getUserMedia requests would not persist decisions on
insecure origins, but media requests from insecure origins through
Pepper would be persisted. However, since M47, getUserMedia requests
from insecure origins are blocked in the renderer, so differentiating
between pepper and non-pepper requests is no longer necessary to know
whether to store the permission decision (any such request is a
Pepper request and can be stored).

This CL removes the plumbing for Pepper requests from the media
permission layer, since it is no longer needed.

BUG=596786
==========

to

==========
Media permissions: Remove plumbing for insecure pepper requests in Chrome

Previously, getUserMedia requests would not persist decisions on
insecure origins, but media requests from insecure origins through
Pepper would be persisted. However, since M47, getUserMedia requests
from insecure origins are blocked in the renderer, so differentiating
between pepper and non-pepper requests is no longer necessary to know
whether to store the permission decision (any such request is a
Pepper request and can be stored).

This CL removes the plumbing for Pepper requests from the media
permission layer, since it is no longer needed.

BUG=596786

Committed: https://crrev.com/e5d5c191121280aa0223615b10d8ab21197ff9b2
Cr-Commit-Position: refs/heads/master@{#399078}
==========

[commit-bot: I haz the power, 2016-06-10 03:36:43]

Patchset 4 (id:??) landed as
https://crrev.com/e5d5c191121280aa0223615b10d8ab21197ff9b2
Cr-Commit-Position: refs/heads/master@{#399078}