Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/BUILD.gn

Issue 1828733004: Load application manifests from resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/mojo/chrome_manifest.json ('K') | « chrome/app/mojo/chrome_renderer_manifest.json ('k') | chrome/browser/browser_resources.grd » ('j') | content/browser/mojo/mojo_child_connection.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 0bc2ce4bcea8e110f02f551e7d9a4f1056f08235..6e47426b4f418aee9d76a38ba919e54eb5f62bdb 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -1020,10 +1020,13 @@ grit("resources") {
rebase_path(additional_modules_list_file, root_build_dir),
"-E",
"root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
+ "-E",
+ "root_out_dir=" + rebase_path(root_out_dir, root_build_dir),
]
deps = [
":chrome_internal_resources_gen",
+ "//chrome/app:mojo_manifests",
# Depend only on the generated mojo bindings since we read the .mojom.js
# file, rather than the whole mojo target which will link the C++ bindings.
« chrome/app/mojo/chrome_manifest.json ('K') | « chrome/app/mojo/chrome_renderer_manifest.json ('k') | chrome/browser/browser_resources.grd » ('j') | content/browser/mojo/mojo_child_connection.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698