Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: mojo/services/catalog/catalog.h

Issue 1828733004: Load application manifests from resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/catalog/catalog.h
diff --git a/mojo/services/catalog/catalog.h b/mojo/services/catalog/catalog.h
index 8f949c3219be4aecde56e63ca02e57f197eff21c..d19de602ef5f65e0469eeb0193df4d945c4cf26e 100644
--- a/mojo/services/catalog/catalog.h
+++ b/mojo/services/catalog/catalog.h
@@ -8,6 +8,7 @@
#include "base/files/file_path.h"
#include "base/memory/weak_ptr.h"
#include "base/path_service.h"
+#include "base/strings/string_piece.h"
#include "base/values.h"
#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/services/catalog/entry.h"
@@ -26,7 +27,17 @@ class Catalog : public mojom::Resolver,
public mojo::shell::mojom::ShellResolver,
public mojom::Catalog {
public:
- Catalog(base::TaskRunner* blocking_pool, scoped_ptr<Store> store);
+ class Delegate {
Ben Goodger (Google) 2016/03/24 22:53:54 top level class, ManifestProvider.
+ public:
+ virtual ~Delegate() {}
+ virtual bool GetApplicationManifest(const base::StringPiece& name,
+ std::string* manifest_contents) = 0;
+ };
+
+ // |delegate| may be null.
+ Catalog(base::TaskRunner* blocking_pool,
+ scoped_ptr<Store> store,
+ Delegate* delegate);
~Catalog() override;
void BindResolver(mojom::ResolverRequest request);
@@ -83,6 +94,8 @@ class Catalog : public mojom::Resolver,
scoped_ptr<Entry> DeserializeApplication(
const base::DictionaryValue* dictionary);
+ Delegate* delegate_;
+
scoped_ptr<Reader> reader_;
base::FilePath package_path_;

Powered by Google App Engine
This is Rietveld 408576698