Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Side by Side Diff: content/browser/BUILD.gn

Issue 1828733004: Load application manifests from resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//content/browser/browser.gni") 7 import("//content/browser/browser.gni")
8 import("//media/media_options.gni") 8 import("//media/media_options.gni")
9 import("//mojo/public/mojo_application_manifest.gni")
10 9
11 source_set("browser") { 10 source_set("browser") {
12 # Only the public target should depend on this. All other targets (even 11 # Only the public target should depend on this. All other targets (even
13 # internal content ones) should depend on the public one. 12 # internal content ones) should depend on the public one.
14 visibility = [ 13 visibility = [
15 ":for_content_tests", # See top of //content/BUILD.gn for why. 14 ":for_content_tests", # See top of //content/BUILD.gn for why.
16 "//content/public/browser:browser_sources", 15 "//content/public/browser:browser_sources",
17 ] 16 ]
18 17
19 configs += [ 18 configs += [
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 "//ui/gfx/geometry", 114 "//ui/gfx/geometry",
116 "//ui/gl", 115 "//ui/gl",
117 "//ui/native_theme", 116 "//ui/native_theme",
118 "//ui/resources", 117 "//ui/resources",
119 "//ui/shell_dialogs", 118 "//ui/shell_dialogs",
120 "//ui/snapshot", 119 "//ui/snapshot",
121 "//ui/surface", 120 "//ui/surface",
122 "//ui/touch_selection", 121 "//ui/touch_selection",
123 ] 122 ]
124 123
125 data_deps = [
126 ":chrome_manifest",
127 ":chrome_renderer_manifest",
128 ]
129
130 sources = rebase_path(content_browser_gypi_values.private_browser_sources, 124 sources = rebase_path(content_browser_gypi_values.private_browser_sources,
131 ".", 125 ".",
132 "//content") 126 "//content")
133 127
134 # TODO(GYP) these generated files are listed as sources in content_browser. 128 # TODO(GYP) these generated files are listed as sources in content_browser.
135 # This is a bit suspicious. The GN grit template will make a source set 129 # This is a bit suspicious. The GN grit template will make a source set
136 # containing the generated code so it should be sufficient to just depend 130 # containing the generated code so it should be sufficient to just depend
137 # on the grit rule. But maybe some of these will need to be added? 131 # on the grit rule. But maybe some of these will need to be added?
138 # 132 #
139 # Need this annoying rebase_path call to match what happened with the 133 # Need this annoying rebase_path call to match what happened with the
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 526
533 # See comment at the top of //content/BUILD.gn for how this works. 527 # See comment at the top of //content/BUILD.gn for how this works.
534 group("for_content_tests") { 528 group("for_content_tests") {
535 visibility = [ "//content/test/*" ] 529 visibility = [ "//content/test/*" ]
536 if (!is_component_build) { 530 if (!is_component_build) {
537 public_deps = [ 531 public_deps = [
538 ":browser", 532 ":browser",
539 ] 533 ]
540 } 534 }
541 } 535 }
542
543 mojo_application_manifest("chrome_manifest") {
544 type = "exe"
545 application_name = "chrome"
546 source = "mojo/chrome_manifest.json"
547 }
548
549 mojo_application_manifest("chrome_renderer_manifest") {
550 type = "exe"
551 application_name = "chrome_renderer"
552 source = "mojo/chrome_renderer_manifest.json"
553 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698