chrome/app/mojo/chrome_manifest.json - Issue 1828733004: Load application manifests from resources

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/mojo/chrome_manifest.json

Issue 1828733004: Load application manifests from resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "manifest_version": 1,	2 "manifest_version": 1,

3 "name": "exe:chrome",	3 "name": "exe:chrome",

4 "display_name": "Chrome",	4 "display_name": "Chrome",
	jam 2016/03/24 17:09:10 why isn't this Chrome Browser, to be consistent wi why isn't this Chrome Browser, to be consistent with "Chrome Renderer" for the renderer process? ditto for filename the reason i bring this up is it's a bit confusing what "chrome" refers to. i.e. is it services in all processes? i realize it's not, but "chrome" is generic and doesn't answer that Ken Rockot(use gerrit already) 2016/03/24 17:33:24 Well, it's not just the browser. The idea is to tr Show quoted text On 2016/03/24 at 17:09:10, jam wrote: > why isn't this Chrome Browser, to be consistent with "Chrome Renderer" for the renderer process? ditto for filename > > the reason i bring this up is it's a bit confusing what "chrome" refers to. i.e. is it services in all processes? i realize it's not, but "chrome" is generic and doesn't answer that Well, it's not just the browser. The idea is to treat Chrome as an app package, so its generated manifest will eventually aggregate other application manifests. This will teach the shell to use exe:chrome's ShellClientFactory when resolving packaged app names. As one example I was going to write a follow-up CL which adds a manifest for mojo:profile and includes it in exe:chrome's package. That would let us get rid of the Loader used for mojo:profile now. Other loaders would follow. I don't really care what we name this, but I think just "Chrome" is good enough for now.
5 "capabilities": {	5 "capabilities": {

6 "required": {	6 "required": {

7 "": { "interfaces": [ "" ] },	7 "": { "interfaces": [ "" ] },

8 "mojo:shell": {	8 "mojo:shell": {

9 "classes": [ "client_process", "instance_name" ],	9 "classes": [ "client_process", "instance_name" ],

10 "interfaces": [ "*" ]	10 "interfaces": [ "*" ]

11 }	11 }

12 }	12 }

13 }	13 }

14 }	14 }

OLD	NEW

« no previous file with comments | « chrome/app/BUILD.gn ('k') | chrome/app/mojo/chrome_renderer_manifest.json » ('j') | content/browser/mojo/mojo_child_connection.cc » ('J')