Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: src/isolate.cc

Issue 18287003: Join threads after stopping. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/marking-thread.cc » ('j') | src/v8.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index fec3dc66ab4260b63b6e8a6023d34961e53536bc..b19cf40ef1de76f9d8b60a715085d8dfedea7bdc 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1873,7 +1873,9 @@ void Isolate::Deinit() {
if (state_ == INITIALIZED) {
TRACE_ISOLATE(deinit);
- if (FLAG_parallel_recompilation) optimizing_compiler_thread_.Stop();
+ if (FLAG_parallel_recompilation) {
+ optimizing_compiler_thread_.Stop();
+ }
if (FLAG_sweeper_threads > 0) {
for (int i = 0; i < FLAG_sweeper_threads; i++) {
@@ -1895,7 +1897,9 @@ void Isolate::Deinit() {
// We must stop the logger before we tear down other components.
Sampler* sampler = logger_->sampler();
- if (sampler && sampler->IsActive()) sampler->Stop();
+ if (sampler && sampler->IsActive()) {
+ sampler->Stop();
+ }
delete deoptimizer_data_;
deoptimizer_data_ = NULL;
« no previous file with comments | « no previous file | src/marking-thread.cc » ('j') | src/v8.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698