Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/sweeper-thread.cc

Issue 18287003: Join threads after stopping. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/optimizing-compiler-thread.cc ('k') | test/cctest/test-mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 return space->free_list()->Concatenate(&free_list_old_data_space_); 86 return space->free_list()->Concatenate(&free_list_old_data_space_);
87 } 87 }
88 return 0; 88 return 0;
89 } 89 }
90 90
91 91
92 void SweeperThread::Stop() { 92 void SweeperThread::Stop() {
93 Release_Store(&stop_thread_, static_cast<AtomicWord>(true)); 93 Release_Store(&stop_thread_, static_cast<AtomicWord>(true));
94 start_sweeping_semaphore_->Signal(); 94 start_sweeping_semaphore_->Signal();
95 stop_semaphore_->Wait(); 95 stop_semaphore_->Wait();
96 Join();
96 } 97 }
97 98
98 99
99 void SweeperThread::StartSweeping() { 100 void SweeperThread::StartSweeping() {
100 start_sweeping_semaphore_->Signal(); 101 start_sweeping_semaphore_->Signal();
101 } 102 }
102 103
103 104
104 void SweeperThread::WaitForSweeperThread() { 105 void SweeperThread::WaitForSweeperThread() {
105 end_sweeping_semaphore_->Wait(); 106 end_sweeping_semaphore_->Wait();
106 } 107 }
107 } } // namespace v8::internal 108 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/optimizing-compiler-thread.cc ('k') | test/cctest/test-mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698