Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: src/marking-thread.cc

Issue 18287003: Join threads after stopping. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 66
67 end_marking_semaphore_->Signal(); 67 end_marking_semaphore_->Signal();
68 } 68 }
69 } 69 }
70 70
71 71
72 void MarkingThread::Stop() { 72 void MarkingThread::Stop() {
73 Release_Store(&stop_thread_, static_cast<AtomicWord>(true)); 73 Release_Store(&stop_thread_, static_cast<AtomicWord>(true));
74 start_marking_semaphore_->Signal(); 74 start_marking_semaphore_->Signal();
75 stop_semaphore_->Wait(); 75 stop_semaphore_->Wait();
76 Join();
76 } 77 }
77 78
78 79
79 void MarkingThread::StartMarking() { 80 void MarkingThread::StartMarking() {
80 start_marking_semaphore_->Signal(); 81 start_marking_semaphore_->Signal();
81 } 82 }
82 83
83 84
84 void MarkingThread::WaitForMarkingThread() { 85 void MarkingThread::WaitForMarkingThread() {
85 end_marking_semaphore_->Wait(); 86 end_marking_semaphore_->Wait();
86 } 87 }
87 88
88 } } // namespace v8::internal 89 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/optimizing-compiler-thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698