Issue 18287003: Join threads after stopping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18287003: Join threads after stopping. (Closed)

Created:
7 years, 5 months ago by Yang

Modified:
7 years, 5 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Join threads after stopping. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15439

Patch Set 2 : addressed comments #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
M	src/marking-thread.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/optimizing-compiler-thread.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/sweeper-thread.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM! good catch, just one nit https://codereview.chromium.org/18287003/diff/1/src/v8.cc File src/v8.cc (right): https://codereview.chromium.org/18287003/diff/1/src/v8.cc#newcode323 src/v8.cc:323: I think we ...

7 years, 5 months ago (2013-07-02 08:56:19 UTC) #2

Yang

7 years, 5 months ago (2013-07-02 09:04:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15439 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18287003: Join threads after stopping. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comments #

Messages