Reland of Android: Run lint using a cache in the output directory (fix-up)

build/android/gyp/lint.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Android's lint tool."""
 
 
 import argparse
@@ skipping 112 matching lines @@
         src_dir = NewSourceDir()
       os.symlink(os.path.abspath(src), PathInDir(src_dir, src))
 
     if manifest_path:
       cmd.append(_RelativizePath(os.path.join(manifest_path, os.pardir)))
 
     if os.path.exists(result_path):
       os.remove(result_path)
 
     env = {}
+    stderr_filter = None
     if cache_dir:
+      # When _JAVA_OPTIONS is set, java prints to stderr:
+      # Picked up _JAVA_OPTIONS: ...
       env['_JAVA_OPTIONS'] = '-Duser.home=%s' % _RelativizePath(cache_dir)
+      stderr_filter = lambda l: '' if '_JAVA_OPTIONS' in l else l

[mlopatkin, 2016/04/06 22:03:11]

Sorry for posting in this closed review but I suppose this immediatelly adds
context to my question.

What is the point of this stderr_filter? Is the intention to only hide "Picked
up.." string from the output? Or to hide Lint's stderr output entirely? The
latter is happening now because build_utils.CheckOutput passes all stderr
content to the filter at once.

A lot of Lint's internal error messages seems to be hidden due to this -
especially CRC errors of interface JARs in classpath.

[agrieve, 2016/04/06 23:55:33]

ooo, nice catch! the intention was to just hide the one line.

Was this something you'd like to help fix up? Otherwise, I can fix it up.

 
     try:
-      build_utils.CheckOutput(cmd, cwd=_SRC_ROOT, env=env or None)
+      build_utils.CheckOutput(cmd, cwd=_SRC_ROOT, env=env or None,
+                              stderr_filter=stderr_filter)
     except build_utils.CalledProcessError:
       if can_fail_build:
         traceback.print_exc()
 
       # There is a problem with lint usage
       if not os.path.exists(result_path):
         raise
 
       # There are actual lint issues
       else:
@@ skipping 31 matching lines @@
 def main():
   parser = argparse.ArgumentParser()
   build_utils.AddDepfileOption(parser)
 
   parser.add_argument('--lint-path', required=True,
                       help='Path to lint executable.')
   parser.add_argument('--product-dir', required=True,
                       help='Path to product dir.')
   parser.add_argument('--result-path', required=True,
                       help='Path to XML lint result file.')
-
-  parser.add_argument('--build-tools-version',
-                      help='Version of the build tools in the Android SDK.')
-  parser.add_argument('--cache-dir',
+  parser.add_argument('--cache-dir', required=True,
                       help='Path to the directory in which the android cache '
                            'directory tree should be stored.')
+  parser.add_argument('--platform-xml-path', required=True,
+                      help='Path to api-platforms.xml')
+  parser.add_argument('--create-cache', action='store_true',
+                      help='Mark the lint cache file as an output rather than '
+                      'an input.')
   parser.add_argument('--can-fail-build', action='store_true',
                       help='If set, script will exit with nonzero exit status'
                            ' if lint errors are present')
   parser.add_argument('--config-path',
                       help='Path to lint suppressions file.')
   parser.add_argument('--enable', action='store_true',
                       help='Run lint instead of just touching stamp.')
   parser.add_argument('--jar-path',
                       help='Jar file containing class files.')
   parser.add_argument('--java-files',
                       help='Paths to java files.')
   parser.add_argument('--manifest-path',
                       help='Path to AndroidManifest.xml')
-  parser.add_argument('--platform-xml-path',
-                      help='Path to api-platforms.xml')
   parser.add_argument('--processed-config-path',
                       help='Path to processed lint suppressions file.')
   parser.add_argument('--resource-dir',
                       help='Path to resource dir.')
   parser.add_argument('--silent', action='store_true',
                       help='If set, script will not log anything.')
   parser.add_argument('--src-dirs',
                       help='Directories containing java files.')
   parser.add_argument('--stamp',
                       help='Path to touch on success.')
 
   args = parser.parse_args()
 
   if args.enable:
     sources = []
     if args.src_dirs:
       src_dirs = build_utils.ParseGypList(args.src_dirs)
       sources = build_utils.FindInDirectories(src_dirs, '*.java')
     elif args.java_files:
       sources = build_utils.ParseGypList(args.java_files)
 
     if args.config_path and not args.processed_config_path:
       parser.error('--config-path specified without --processed-config-path')
     elif args.processed_config_path and not args.config_path:
       parser.error('--processed-config-path specified without --config-path')
 
     input_paths = [
         args.lint_path,
+        args.platform_xml_path,
     ]
     if args.config_path:
       input_paths.append(args.config_path)
     if args.jar_path:
       input_paths.append(args.jar_path)
     if args.manifest_path:
       input_paths.append(args.manifest_path)
-    if args.platform_xml_path:
-      input_paths.append(args.platform_xml_path)
     if args.resource_dir:
       input_paths.extend(build_utils.FindInDirectory(args.resource_dir, '*'))
     if sources:
       input_paths.extend(sources)
 
     input_strings = []
     if args.processed_config_path:
       input_strings.append(args.processed_config_path)
 
     output_paths = [ args.result_path ]
-    if args.cache_dir:
-      if not args.build_tools_version:
-        parser.error('--cache-dir specified without --build-tools-version')
-      output_paths.append(os.path.join(
-          args.cache_dir, '.android', 'cache',
-          'api-versions-6-%s.bin' % args.build_tools_version))
 
     build_utils.CallAndWriteDepfileIfStale(
         lambda changes: _OnStaleMd5(changes, args.lint_path,
                                     args.config_path,
                                     args.processed_config_path,
                                     args.manifest_path, args.result_path,
                                     args.product_dir, sources,
                                     args.jar_path,
                                     args.cache_dir,
                                     resource_dir=args.resource_dir,
                                     can_fail_build=args.can_fail_build,
                                     silent=args.silent),
         args,
         input_paths=input_paths,
         input_strings=input_strings,
         output_paths=output_paths,
         pass_changes=True)
 
 
 if __name__ == '__main__':
   sys.exit(main())