Reland of Android: Run lint using a cache in the output directory (fix-up)

Reland of Android: Run lint using a cache in the output directory (fix-up)

No longer trying to guess name of cached .bin file.

Previous commit forgot to set --cache-dir for GN.

BUG=583661, 597251
Committed: https://crrev.com/070509bda8b8b74d8963907bd5f79909da043c34
Cr-Commit-Position: refs/heads/master@{#382871}

[agrieve, 2016-03-23 14:32:41]

Created Reland of 🌈 Android: Run lint using a cache in the output directory
(fix-up)

[agrieve, 2016-03-23 14:33:59]

Description was changed from

==========
Reland of 🌈 Android: Run lint using a cache in the output directory (fix-up)
(patchset #1 id:1 of https://codereview.chromium.org/1829683002/ )

Reason for revert:
fixing...

Original issue's description:
> Revert of 🌈 Android: Run lint using a cache in the output directory (fix-up)
(patchset #2 id:20001 of https://codereview.chromium.org/1824093002/ )
> 
> Reason for revert:
> Breaks on Android 64bit unpublished builders
> 
> BUG=597251
> 
> Original issue's description:
> > Android: Run lint using a cache in the output directory (fix-up)
> >
> > Previous commit forgot to set --cache-dir for GN.
> >
> > BUG=583661
> >
> > Committed: https://crrev.com/99748af41ad073389f3f38274a024a830585609c
> > Cr-Commit-Position: refs/heads/master@{#382699}
> 
> TBR=jbudorick@chromium.org,agrieve@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=583661
> 
> Committed: https://crrev.com/62cc80409b326670a7faafb3db806451fa6cc812
> Cr-Commit-Position: refs/heads/master@{#382838}

TBR=jbudorick@chromium.org,aberent@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=597251
==========

to

==========
Reland of Android: Run lint using a cache in the output directory (fix-up)

No longer trying to guess name of cached .bin file.

Previous commit forgot to set --cache-dir for GN.

BUG=583661,597251
==========

[agrieve, 2016-03-23 14:38:42]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 14:38:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828693002/80002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828693002/80002

[jbudorick, 2016-03-23 15:04:17]

lgtm

[commit-bot: I haz the power, 2016-03-23 15:45:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 15:45:20]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-03-23 17:20:48]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-03-23 17:21:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828693002/80002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828693002/80002

[commit-bot: I haz the power, 2016-03-23 17:26:50]

Description was changed from

==========
Reland of Android: Run lint using a cache in the output directory (fix-up)

No longer trying to guess name of cached .bin file.

Previous commit forgot to set --cache-dir for GN.

BUG=583661,597251
==========

to

==========
Reland of Android: Run lint using a cache in the output directory (fix-up)

No longer trying to guess name of cached .bin file.

Previous commit forgot to set --cache-dir for GN.

BUG=583661,597251
==========

[commit-bot: I haz the power, 2016-03-23 17:26:51]

Committed patchset #2 (id:80002)

[commit-bot: I haz the power, 2016-03-23 17:28:03]

Description was changed from

==========
Reland of Android: Run lint using a cache in the output directory (fix-up)

No longer trying to guess name of cached .bin file.

Previous commit forgot to set --cache-dir for GN.

BUG=583661,597251
==========

to

==========
Reland of Android: Run lint using a cache in the output directory (fix-up)

No longer trying to guess name of cached .bin file.

Previous commit forgot to set --cache-dir for GN.

BUG=583661,597251

Committed: https://crrev.com/070509bda8b8b74d8963907bd5f79909da043c34
Cr-Commit-Position: refs/heads/master@{#382871}
==========

[commit-bot: I haz the power, 2016-03-23 17:28:04]

Patchset 2 (id:??) landed as
https://crrev.com/070509bda8b8b74d8963907bd5f79909da043c34
Cr-Commit-Position: refs/heads/master@{#382871}

[mlopatkin, 2016-04-06 22:03:11]

https://codereview.chromium.org/1828693002/diff/80002/build/android/gyp/lint.py
File build/android/gyp/lint.py (right):

https://codereview.chromium.org/1828693002/diff/80002/build/android/gyp/lint....
build/android/gyp/lint.py:138: stderr_filter = lambda l: '' if '_JAVA_OPTIONS'
in l else l
Sorry for posting in this closed review but I suppose this immediatelly adds
context to my question.

What is the point of this stderr_filter? Is the intention to only hide "Picked
up.." string from the output? Or to hide Lint's stderr output entirely? The
latter is happening now because build_utils.CheckOutput passes all stderr
content to the filter at once.

A lot of Lint's internal error messages seems to be hidden due to this -
especially CRC errors of interface JARs in classpath.

[agrieve, 2016-04-06 23:55:33]

https://codereview.chromium.org/1828693002/diff/80002/build/android/gyp/lint.py
File build/android/gyp/lint.py (right):

https://codereview.chromium.org/1828693002/diff/80002/build/android/gyp/lint....
build/android/gyp/lint.py:138: stderr_filter = lambda l: '' if '_JAVA_OPTIONS'
in l else l
On 2016/04/06 22:03:11, mlopatkin wrote:
> Sorry for posting in this closed review but I suppose this immediatelly adds
> context to my question.
> 
> What is the point of this stderr_filter? Is the intention to only hide "Picked
> up.." string from the output? Or to hide Lint's stderr output entirely? The
> latter is happening now because build_utils.CheckOutput passes all stderr
> content to the filter at once.
> 
> A lot of Lint's internal error messages seems to be hidden due to this -
> especially CRC errors of interface JARs in classpath.

ooo, nice catch! the intention was to just hide the one line.

Was this something you'd like to help fix up? Otherwise, I can fix it up.

[mlopatkin, 2016-04-07 12:33:57]

On 2016/04/06 23:55:33, agrieve wrote:
>
https://codereview.chromium.org/1828693002/diff/80002/build/android/gyp/lint.py
> File build/android/gyp/lint.py (right):
> 
>
https://codereview.chromium.org/1828693002/diff/80002/build/android/gyp/lint....
> build/android/gyp/lint.py:138: stderr_filter = lambda l: '' if '_JAVA_OPTIONS'
> in l else l
> On 2016/04/06 22:03:11, mlopatkin wrote:
> > Sorry for posting in this closed review but I suppose this immediatelly adds
> > context to my question.
> > 
> > What is the point of this stderr_filter? Is the intention to only hide
"Picked
> > up.." string from the output? Or to hide Lint's stderr output entirely? The
> > latter is happening now because build_utils.CheckOutput passes all stderr
> > content to the filter at once.
> > 
> > A lot of Lint's internal error messages seems to be hidden due to this -
> > especially CRC errors of interface JARs in classpath.
> 
> ooo, nice catch! the intention was to just hide the one line.
> 
> Was this something you'd like to help fix up? Otherwise, I can fix it up.

I'll fix it along with most errors that this thing is hiding now.