Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1828673002: Fix build on win/clang (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix build on win/clang EmbeddedCharcodeFromUnicode is not used on windows anymore and clang complains. TBR=weili@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/db98f18c7e1268f59166cd9dfd0c896efb187b88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
dsinclair
Committed patchset #1 (id:1) manually as db98f18c7e1268f59166cd9dfd0c896efb187b88 (tree was closed).
4 years, 9 months ago (2016-03-23 13:35:29 UTC) #2
Wei Li
4 years, 9 months ago (2016-03-23 16:47:10 UTC) #3
Message was sent while issue was closed. 
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698