Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 1828663002: [v8] Mark layout tests for rebase on ES6 instanceof. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[v8] Mark layout tests for rebase on ES6 instanceof. This marks two layout tests for manual rebase after new ES6 instanceof semantics have shipped in V8 and stabilized. One test just produces a different error message, the other runs out of stack earlier. Both changes are expected and don't indicate a bug in ES6 instanceof. R=hablich@chromium.org BUG=chromium:597221, v8:4447 Committed: https://crrev.com/660ee3c9fc851b47bc17c086ae5222d1e6212e60 Cr-Commit-Position: refs/heads/master@{#382847}

Patch Set 1 #

Patch Set 2 : Accidental change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-23 10:12:33 UTC) #1
Michael Hablich
lgtm
4 years, 9 months ago (2016-03-23 10:26:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828663002/20001
4 years, 9 months ago (2016-03-23 10:26:13 UTC) #4
Michael Achenbach
lgtm
4 years, 9 months ago (2016-03-23 10:30:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/200858)
4 years, 9 months ago (2016-03-23 12:46:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828663002/20001
4 years, 9 months ago (2016-03-23 12:47:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 15:02:14 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 15:04:03 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/660ee3c9fc851b47bc17c086ae5222d1e6212e60
Cr-Commit-Position: refs/heads/master@{#382847}

Powered by Google App Engine
This is Rietveld 408576698