[Interpreter] Enable tracing of bytecode handler dispatches.

src/d8.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 // Defined when linking against shared lib on Windows.
 #if defined(USING_V8_SHARED) && !defined(V8_SHARED)
 #define V8_SHARED
 #endif
 
 #include <errno.h>
 #include <stdlib.h>
 #include <string.h>
 #include <sys/stat.h>
+#include <fstream>
 
 #ifdef V8_SHARED
 #include <assert.h>
 #endif  // V8_SHARED
 
 #ifndef V8_SHARED
 #include <algorithm>
 #include <vector>
 #endif  // !V8_SHARED
 
 #ifdef V8_SHARED
 #include "include/v8-testing.h"
 #endif  // V8_SHARED
 
 #ifdef ENABLE_VTUNE_JIT_INTERFACE
 #include "src/third_party/vtune/v8-vtune.h"
 #endif
 
 #include "src/d8.h"
 #include "src/ostreams.h"
 
 #include "include/libplatform/libplatform.h"
 #ifndef V8_SHARED
 #include "src/api.h"
 #include "src/base/cpu.h"
 #include "src/base/logging.h"
 #include "src/base/platform/platform.h"
 #include "src/base/sys-info.h"
 #include "src/basic-block-profiler.h"
+#include "src/interpreter/interpreter.h"
 #include "src/snapshot/natives.h"
 #include "src/utils.h"
 #include "src/v8.h"
 #endif  // !V8_SHARED
 
 #if !defined(_WIN32) && !defined(_WIN64)
 #include <unistd.h>  // NOLINT
 #else
 #include <windows.h>  // NOLINT
 #if defined(_MSC_VER)
@@ skipping 1214 matching lines @@
 #ifndef V8_SHARED
 struct CounterAndKey {
   Counter* counter;
   const char* key;
 };
 
 
 inline bool operator<(const CounterAndKey& lhs, const CounterAndKey& rhs) {
   return strcmp(lhs.key, rhs.key) < 0;
 }
+
+void Shell::WriteInterpreterDispatchCounters(Isolate* isolate) {
+  std::ofstream stream(i::FLAG_trace_ignition_dispatches_output_file);
+
+  uintptr_t* handler_to_handler_dispatch_counters =
+      reinterpret_cast<i::Isolate*>(isolate)
+          ->interpreter()
+          ->handler_to_handler_dispatch_counters();
+
+  int kCountersTableRowSize =

[rmcilroy, 2016/04/08 11:24:43]

static const

[Stefano Sanfilippo, 2016/04/08 14:42:44]

Done.

+      static_cast<int>(i::interpreter::Bytecode::kLast) + 1;
+
+  stream << '[';
+
+  for (int from_index = 0; from_index < kCountersTableRowSize; ++from_index) {
+    if (from_index > 0) stream << ",\n ";
+
+    // Do not use an object, we need the order of entries to be preserved

[rmcilroy, 2016/04/08 11:24:43]

Not sure what this comment means? Also, could we have the output be a dictionary
of named target bytecode (only for those target bytecodes with a dispatch count
> 0) rather than an ordered list. Relying on the ordering of the source
bytecodes to show the order of the unnamed target bytecode list seems brittle.

[Stefano Sanfilippo, 2016/04/08 14:42:44]

Replaced with dictionary of dictionaries.

+    i::interpreter::Bytecode from_bytecode =
+        i::interpreter::Bytecodes::FromByte(from_index);
+    stream << "[\"" << i::interpreter::Bytecodes::ToString(from_bytecode)
+           << "\", [";
+
+    for (int to_index = 0; to_index < kCountersTableRowSize; ++to_index) {
+      if (to_index > 0) stream << ", ";
+      stream << handler_to_handler_dispatch_counters[from_index *
+                                                         kCountersTableRowSize +
+                                                     to_index];
+    }
+    stream << "]]";
+  }
+  stream << ']';
+}
+
 #endif  // !V8_SHARED
 
 
 void Shell::OnExit(v8::Isolate* isolate) {
 #ifndef V8_SHARED
   if (i::FLAG_dump_counters) {
     int number_of_counters = 0;
     for (CounterMap::Iterator i(counter_map_); i.More(); i.Next()) {
       number_of_counters++;
     }
@@ skipping 17 matching lines @@
         printf("| c:%-60s | %11i |\n", key, counter->count());
         printf("| t:%-60s | %11i |\n", key, counter->sample_total());
       } else {
         printf("| %-62s | %11i |\n", key, counter->count());
       }
     }
     printf("+----------------------------------------------------------------+"
            "-------------+\n");
     delete [] counters;
   }
+
+  if (i::FLAG_trace_ignition_dispatches) {
+    WriteInterpreterDispatchCounters(isolate);
+  }
+
   delete counters_file_;
   delete counter_map_;
 #endif  // !V8_SHARED
 }
 
 
 
 static FILE* FOpen(const char* path, const char* mode) {
 #if defined(_MSC_VER) && (defined(_WIN32) || defined(_WIN64))
   FILE* result;
@@ skipping 1173 matching lines @@
 }
 
 }  // namespace v8
 
 
 #ifndef GOOGLE3
 int main(int argc, char* argv[]) {
   return v8::Shell::Main(argc, argv);
 }
 #endif