Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 182863007: Pre-emptively add an (unused) #define for record-time filter scaling. (Closed)

Created:
6 years, 9 months ago by Stephen White
Modified:
6 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews
Visibility:
Public.

Description

Pre-emptively add an (unused) #define for record-time filter scaling. This will be used in Blink to protect the old implementation of hiDPI filter scaling. Once CC has been taught how to apply hiDPI to filters, the Blink implementation will be switched off at the same time by removing this #define. BUG=281516 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Stephen White
danakj: PTAL. Thanks!
6 years, 9 months ago (2014-03-06 19:02:39 UTC) #1
danakj
LGTM
6 years, 9 months ago (2014-03-06 19:04:43 UTC) #2
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 9 months ago (2014-03-06 19:12:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/182863007/1
6 years, 9 months ago (2014-03-06 19:15:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 19:39:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 9 months ago (2014-03-06 19:39:51 UTC) #6
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 9 months ago (2014-03-06 20:43:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/182863007/1
6 years, 9 months ago (2014-03-06 21:00:25 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 21:29:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 21:29:14 UTC) #10
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 9 months ago (2014-03-06 21:29:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/182863007/1
6 years, 9 months ago (2014-03-06 21:35:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/182863007/1
6 years, 9 months ago (2014-03-06 22:11:28 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 11:27:04 UTC) #14
Message was sent while issue was closed.
Change committed as 255580

Powered by Google App Engine
This is Rietveld 408576698