Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1828623002: Make Editor::tidyUpHTMLStructure() handles BODY element correctly (Closed)

Created:
4 years, 9 months ago by yosin_UTC9
Modified:
4 years, 9 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Editor::tidyUpHTMLStructure() handles BODY element correctly This patch makes |Editor::tidyUpHTMLStructure()| to handle BODY element correctly when it is document element. Before this patch, |Editor::tidyUpHTMLStructure()| attempt to move existing BODY element itself, this patch checks this case and not to move it into itself. This patch also exports HEAD element to use in unit test and adds "HTMLHeadElement.h" into GYPI file for sane. BUG=595606 TEST=run_webkit_unittests --gtest_filter=EditorTest.tidyUpHTMLStructure* Committed: https://crrev.com/f0371cdb39e34540ebb9ea0daaa962976b551b56 Cr-Commit-Position: refs/heads/master@{#382811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -2 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/editing/EditorTest.cpp View 1 chunk +66 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLHeadElement.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
yosin_UTC9
PTAL Actual changes are: # OLD if (document.documentElement()) body->appendChild(document.documentElement()); # NEW if (document.documentElement() && body ...
4 years, 9 months ago (2016-03-23 05:50:20 UTC) #3
tkent
lgtm. Thank you for fixing this and adding tests.
4 years, 9 months ago (2016-03-23 06:04:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828623002/1
4 years, 9 months ago (2016-03-23 06:15:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/200788)
4 years, 9 months ago (2016-03-23 07:54:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828623002/1
4 years, 9 months ago (2016-03-23 08:14:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 09:13:54 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 09:15:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0371cdb39e34540ebb9ea0daaa962976b551b56
Cr-Commit-Position: refs/heads/master@{#382811}

Powered by Google App Engine
This is Rietveld 408576698