Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1828613002: Sk4x4f: NEON impl. (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
herb_g, msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sk4x4f: NEON impl. Notable tricks: - v{ld,st}4q_f32 handle transposing loads and stores of floats in one step - vcvtq_n_{f32_u32,u32_f32} let us do conversion to and from floats without shifts BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1828613002 Committed: https://skia.googlesource.com/skia/+/1fd50acbaa1e26f892ad810a67cb3fa90b039c85

Patch Set 1 #

Patch Set 2 : TODOne #

Patch Set 3 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -22 lines) Patch
M src/core/Sk4x4f.h View 1 2 4 chunks +44 lines, -22 lines 1 comment Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828613002/40001
4 years, 9 months ago (2016-03-23 23:04:48 UTC) #4
mtklein_C
I know you're eager to learn NEON. Want to have a look here? I can ...
4 years, 9 months ago (2016-03-23 23:16:17 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-23 23:16:19 UTC) #8
mtklein_C
+Matt, who may be interested to see that we've finally found a use for vcvtq_n_f32_u32.
4 years, 9 months ago (2016-03-24 02:03:31 UTC) #10
msarett
lgtm in case you need one of those :) https://codereview.chromium.org/1828613002/diff/40001/src/core/Sk4x4f.h File src/core/Sk4x4f.h (right): https://codereview.chromium.org/1828613002/diff/40001/src/core/Sk4x4f.h#newcode91 src/core/Sk4x4f.h:91: ...
4 years, 9 months ago (2016-03-24 17:00:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828613002/40001
4 years, 9 months ago (2016-03-24 17:11:46 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 17:12:44 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/1fd50acbaa1e26f892ad810a67cb3fa90b039c85

Powered by Google App Engine
This is Rietveld 408576698