content/browser/appcache/chrome_appcache_service_unittest.cc - Issue 18286004: Move PathExists to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/chrome_appcache_service_unittest.cc

Issue 18286004: Move PathExists to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/dump_accessibility_tree_browsertest.cc ('k') | content/browser/download/base_file_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/chrome_appcache_service_unittest.cc

diff --git a/content/browser/appcache/chrome_appcache_service_unittest.cc b/content/browser/appcache/chrome_appcache_service_unittest.cc

index ebcca07393e4336f28cceb145d51f93f761d28ae..11d736e9f34e827ec8e1973faccf288a7b13721a 100644

--- a/content/browser/appcache/chrome_appcache_service_unittest.cc

+++ b/content/browser/appcache/chrome_appcache_service_unittest.cc

@@ -154,8 +154,8 @@ TEST_F(ChromeAppCacheServiceTest, KeepOnDestruction) {

// Create a ChromeAppCacheService and insert data into it

scoped_refptr<ChromeAppCacheService> appcache_service =

CreateAppCacheService(appcache_path, true);

- ASSERT_TRUE(file_util::PathExists(appcache_path));

- ASSERT_TRUE(file_util::PathExists(appcache_path.AppendASCII("Index")));

+ ASSERT_TRUE(base::PathExists(appcache_path));

+ ASSERT_TRUE(base::PathExists(appcache_path.AppendASCII("Index")));

InsertDataIntoAppCache(appcache_service.get());

// Test: delete the ChromeAppCacheService

@@ -166,7 +166,7 @@ TEST_F(ChromeAppCacheServiceTest, KeepOnDestruction) {

appcache_service = CreateAppCacheService(appcache_path, false);

// The directory is still there

- ASSERT_TRUE(file_util::PathExists(appcache_path));

+ ASSERT_TRUE(base::PathExists(appcache_path));

// The appcache data is also there, except the session-only origin.

AppCacheTestHelper appcache_helper;

@@ -191,8 +191,8 @@ TEST_F(ChromeAppCacheServiceTest, SaveSessionState) {

// Create a ChromeAppCacheService and insert data into it

scoped_refptr<ChromeAppCacheService> appcache_service =

CreateAppCacheService(appcache_path, true);

- ASSERT_TRUE(file_util::PathExists(appcache_path));

- ASSERT_TRUE(file_util::PathExists(appcache_path.AppendASCII("Index")));

+ ASSERT_TRUE(base::PathExists(appcache_path));

+ ASSERT_TRUE(base::PathExists(appcache_path.AppendASCII("Index")));

InsertDataIntoAppCache(appcache_service.get());

// Save session state. This should bypass the destruction-time deletion.

@@ -206,7 +206,7 @@ TEST_F(ChromeAppCacheServiceTest, SaveSessionState) {

appcache_service = CreateAppCacheService(appcache_path, false);

// The directory is still there

- ASSERT_TRUE(file_util::PathExists(appcache_path));

+ ASSERT_TRUE(base::PathExists(appcache_path));

// No appcache data was deleted.

AppCacheTestHelper appcache_helper;