chrome/browser/safe_browsing/download_feedback_service_unittest.cc - Issue 18286004: Move PathExists to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_feedback_service_unittest.cc

Issue 18286004: Move PathExists to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/pepper/device_id_fetcher.cc ('k') | chrome/browser/safe_browsing/download_feedback_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_feedback_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/download_feedback_service_unittest.cc b/chrome/browser/safe_browsing/download_feedback_service_unittest.cc

index a912a3f7f0794d86d5b831803f6c7720e4d052db..167e622b7569f10b0ca0b30bbdbd9b9a459cb139 100644

--- a/chrome/browser/safe_browsing/download_feedback_service_unittest.cc

+++ b/chrome/browser/safe_browsing/download_feedback_service_unittest.cc

@@ -229,7 +229,7 @@ TEST_F(DownloadFeedbackServiceTest, SingleFeedbackComplete) {

// File should still exist since our FakeDownloadFeedback does not delete it.

base::RunLoop().RunUntilIdle();

- EXPECT_TRUE(file_util::PathExists(file_path));

+ EXPECT_TRUE(base::PathExists(file_path));

}

TEST_F(DownloadFeedbackServiceTest, MultiplePendingFeedbackComplete) {

@@ -296,9 +296,9 @@ TEST_F(DownloadFeedbackServiceTest, MultiplePendingFeedbackComplete) {

base::RunLoop().RunUntilIdle();

// These files should still exist since the FakeDownloadFeedback does not

// delete them.

- EXPECT_TRUE(file_util::PathExists(file_path[0]));

- EXPECT_TRUE(file_util::PathExists(file_path[1]));

- EXPECT_TRUE(file_util::PathExists(file_path[2]));

+ EXPECT_TRUE(base::PathExists(file_path[0]));

+ EXPECT_TRUE(base::PathExists(file_path[1]));

+ EXPECT_TRUE(base::PathExists(file_path[2]));

}

TEST_F(DownloadFeedbackServiceTest, MultiFeedbackWithIncomplete) {

@@ -361,17 +361,17 @@ TEST_F(DownloadFeedbackServiceTest, MultiFeedbackWithIncomplete) {

EXPECT_EQ(2U, num_feedbacks());

// File should still exist since the FileUtilProxy task hasn't run yet.

- EXPECT_TRUE(file_util::PathExists(file_path[2]));

+ EXPECT_TRUE(base::PathExists(file_path[2]));

base::RunLoop().RunUntilIdle();

// File should be deleted since the AcquireFileCallback ran after the service

// was deleted.

- EXPECT_FALSE(file_util::PathExists(file_path[2]));

+ EXPECT_FALSE(base::PathExists(file_path[2]));

// These files should still exist since the FakeDownloadFeedback does not

// delete them.

- EXPECT_TRUE(file_util::PathExists(file_path[0]));

- EXPECT_TRUE(file_util::PathExists(file_path[1]));

+ EXPECT_TRUE(base::PathExists(file_path[0]));

+ EXPECT_TRUE(base::PathExists(file_path[1]));

}

} // namespace safe_browsing