chrome/browser/extensions/api/storage/settings_frontend_unittest.cc - Issue 18286004: Move PathExists to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

Issue 18286004: Move PathExists to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/record/record_api.cc ('k') | chrome/browser/extensions/api/storage/storage_schema_manifest_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

diff --git a/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc b/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

index 97055316d597839f22a2f2f17007873562fbcae0..fe0f6604d365f72be795c0e87c96cc3798239b7c 100644

--- a/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

+++ b/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc

@@ -165,7 +165,7 @@ TEST_F(ExtensionSettingsFrontendTest, LeveldbDatabaseDeletedFromDiskOnClear) {

StringValue bar("bar");

ValueStore::WriteResult result = storage->Set(DEFAULTS, "foo", bar);

ASSERT_FALSE(result->HasError());

- EXPECT_TRUE(file_util::PathExists(temp_dir_.path()));

+ EXPECT_TRUE(base::PathExists(temp_dir_.path()));

}

// Should need to both clear the database and delete the frontend for the

@@ -173,7 +173,7 @@ TEST_F(ExtensionSettingsFrontendTest, LeveldbDatabaseDeletedFromDiskOnClear) {

{

ValueStore::WriteResult result = storage->Clear();

ASSERT_FALSE(result->HasError());

- EXPECT_TRUE(file_util::PathExists(temp_dir_.path()));

+ EXPECT_TRUE(base::PathExists(temp_dir_.path()));

}

frontend_.reset();

@@ -181,7 +181,7 @@ TEST_F(ExtensionSettingsFrontendTest, LeveldbDatabaseDeletedFromDiskOnClear) {

// TODO(kalman): Figure out why this fails, despite appearing to work.

// Leaving this commented out rather than disabling the whole test so that the

// deletion code paths are at least exercised.

- //EXPECT_FALSE(file_util::PathExists(temp_dir_.path()));

+ //EXPECT_FALSE(base::PathExists(temp_dir_.path()));

}

TEST_F(ExtensionSettingsFrontendTest,