Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: chrome/common/extensions/manifest_url_handler.cc

Issue 18286004: Move PathExists to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_url_handler.h" 5 #include "chrome/common/extensions/manifest_url_handler.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 std::vector<InstallWarning>* warnings) const { 233 std::vector<InstallWarning>* warnings) const {
234 // Validate path to the options page. Don't check the URL for hosted apps, 234 // Validate path to the options page. Don't check the URL for hosted apps,
235 // because they are expected to refer to an external URL. 235 // because they are expected to refer to an external URL.
236 if (!extensions::ManifestURL::GetOptionsPage(extension).is_empty() && 236 if (!extensions::ManifestURL::GetOptionsPage(extension).is_empty() &&
237 !extension->is_hosted_app()) { 237 !extension->is_hosted_app()) {
238 const base::FilePath options_path = 238 const base::FilePath options_path =
239 extension_file_util::ExtensionURLToRelativeFilePath( 239 extension_file_util::ExtensionURLToRelativeFilePath(
240 extensions::ManifestURL::GetOptionsPage(extension)); 240 extensions::ManifestURL::GetOptionsPage(extension));
241 const base::FilePath path = 241 const base::FilePath path =
242 extension->GetResource(options_path).GetFilePath(); 242 extension->GetResource(options_path).GetFilePath();
243 if (path.empty() || !file_util::PathExists(path)) { 243 if (path.empty() || !base::PathExists(path)) {
244 *error = 244 *error =
245 l10n_util::GetStringFUTF8( 245 l10n_util::GetStringFUTF8(
246 IDS_EXTENSION_LOAD_OPTIONS_PAGE_FAILED, 246 IDS_EXTENSION_LOAD_OPTIONS_PAGE_FAILED,
247 options_path.LossyDisplayName()); 247 options_path.LossyDisplayName());
248 return false; 248 return false;
249 } 249 }
250 } 250 }
251 return true; 251 return true;
252 } 252 }
253 253
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 extension->SetManifestData(keys::kChromeURLOverrides, 321 extension->SetManifestData(keys::kChromeURLOverrides,
322 url_overrides.release()); 322 url_overrides.release());
323 return true; 323 return true;
324 } 324 }
325 325
326 const std::vector<std::string> URLOverridesHandler::Keys() const { 326 const std::vector<std::string> URLOverridesHandler::Keys() const {
327 return SingleKey(keys::kChromeURLOverrides); 327 return SingleKey(keys::kChromeURLOverrides);
328 } 328 }
329 329
330 } // namespace extensions 330 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifest_test.cc ('k') | chrome/common/extensions/unpacker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698