Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1828543007: Add new semantics + compat fallback to Intl constructor

Created:
4 years, 9 months ago by Dan Ehrenberg
Modified:
4 years, 8 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add new semantics + compat fallback to Intl constructor ECMA 402 v2 made Intl constructors more strict in terms of how they would initialize objects, refusing to initialize objects which have already been constructed. However, when Chrome tried to ship these semantics, we ran into web compatibility issues. This patch tries to square the circle and implement the simpler v2 object semantics while including a compatibility workaround to allow objects to sort of be initialized later, storing the real underlying Intl object in a symbol-named property. BUG=v8:4360, v8:4870 LOG=Y R=adamk

Patch Set 1 #

Patch Set 2 : Test and better checking #

Patch Set 3 : Simplify tests #

Patch Set 4 : Add tests; make more minimal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -91 lines) Patch
M src/js/i18n.js View 1 2 3 15 chunks +85 lines, -85 lines 0 comments Download
M src/messages.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/intl/assert.js View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A test/intl/general/constructor.js View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4870.js View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828543007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828543007/20001
4 years, 9 months ago (2016-03-25 02:53:41 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 03:09:04 UTC) #5
Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

Powered by Google App Engine
This is Rietveld 408576698