Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: chrome/test/nacl/nacl_browsertest.cc

Issue 1828533002: Enable UMA histogram logger for low memor kill events in ArcMetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix NaClBrowserTest Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/nacl/nacl_browsertest.cc
diff --git a/chrome/test/nacl/nacl_browsertest.cc b/chrome/test/nacl/nacl_browsertest.cc
index 784165ca96151c51a9cafc4c9707b68c8aba6621..ee6a08b12a6600edc6f17462f7de010f3410cab8 100644
--- a/chrome/test/nacl/nacl_browsertest.cc
+++ b/chrome/test/nacl/nacl_browsertest.cc
@@ -192,7 +192,8 @@ base::FilePath::StringType NumberOfCoresAsFilePathString() {
long nprocessors = sysconf(_SC_NPROCESSORS_ONLN);
#if TELEMETRY
fprintf(stderr, "browser says nprocessors = %ld\n", nprocessors);
- fflush(NULL);
+ // crbug.com/597899
Mark Seaborn 2016/03/25 21:26:25 This reference isn't really necessary -- the absen
cylee1 2016/03/25 21:34:03 Ye.. But anyway I think it doesn't hurt to keep it
+ fflush(stderr);
#endif
snprintf(string_rep, sizeof string_rep, "%ld", nprocessors);
return string_rep;
@@ -205,7 +206,8 @@ base::FilePath::StringType NumberOfCoresAsFilePathString() {
#if TELEMETRY
fprintf(stderr, "browser says nprocessors = %lu\n",
system_info.dwNumberOfProcessors);
- fflush(NULL);
+ // crbug.com/597899
+ fflush(stderr);
#endif
_snwprintf_s(string_rep, sizeof string_rep / sizeof string_rep[0], _TRUNCATE,
L"%u", system_info.dwNumberOfProcessors);
@@ -216,11 +218,12 @@ base::FilePath::StringType NumberOfCoresAsFilePathString() {
#if TELEMETRY
static void PathTelemetry(base::FilePath::StringType const &path) {
# if defined(OS_WIN)
- fwprintf(stderr, L"path = %s\n", path.c_str());
+ fwprintf(stderr, L"path = %s\n", path.c_str());
# else
- fprintf(stderr, "path = %s\n", path.c_str());
+ fprintf(stderr, "path = %s\n", path.c_str());
# endif
- fflush(NULL);
+ // crbug.com/597899
+ fflush(stderr);
}
#else
static void PathTelemetry(base::FilePath::StringType const &path) {
« no previous file with comments | « chrome/chrome_browser_chromeos.gypi ('k') | components/arc.gypi » ('j') | components/arc/DEPS » ('J')

Powered by Google App Engine
This is Rietveld 408576698